Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/38#discussion_r13929737
  
    --- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java 
---
    @@ -135,6 +135,16 @@ public ShellMsg readShellMsg() throws IOException, 
NoOutputException {
                     shellMsg.addAnchor((String) o);
                 }
             }
    +       
    +        Object nameObj = msg.get("name"); 
    --- End diff --
    
    "name" and "params" both feel kind of too generic. It would be nice if they 
had metric in them somehow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to