I reviewed the patch and I think it’s good. It removes quite a lot of messy code.
There’s a DEP in progress about allowing dependencies here: https://github.com/django/deps/pull/26 <https://github.com/django/deps/pull/26> It looks like that there’s consensus on the general idea of allowing dependencies and on pytz being an acceptable dependency, and that the DEP isn’t finished simply because no one has taken the time to finish it. If some contributors are uncomfortable with preempting the discussion of that DEP or don’t think there’s consensus, now’s a good time to say so :-) Tim, you could also ask for the technical board’s opinion if you want. -- Aymeric. > On 08 Oct 2016, at 14:13, Tim Graham <timogra...@gmail.com> wrote: > > I created a ticket and PR to add pytz to install_requires. I think it's a > nice simplification and will result in a better user experience. > https://code.djangoproject.com/ticket/27327 > <https://code.djangoproject.com/ticket/27327> > https://github.com/django/django/pull/7361 > <https://github.com/django/django/pull/7361> > > On Monday, June 6, 2016 at 5:28:11 AM UTC-4, Aymeric Augustin wrote: > > On 06 Jun 2016, at 03:46, Carl Meyer <ca...@oddbird.net <javascript:>> > > wrote: > > > >> django-admin.py startproject defaults to USE_TZ = True which means that > >> new projects that install django, start the project, and then run the > >> internal web server are going to get missing dependency problems. > > > > That's an excellent point. I agree, we should just add pytz to > > install_requires if we require it for USE_TZ=True, otherwise the default > > new-project experience is unpleasant. > > I agree as well. > > One of these days we should reverse the “actual default value” so we don’t > have to override it in the “default project template” (and then people > obviously have no idea what the “default” is…) > > -- > Aymeric. > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com > <mailto:django-developers+unsubscr...@googlegroups.com>. > To post to this group, send email to django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at https://groups.google.com/group/django-developers > <https://groups.google.com/group/django-developers>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/5c96fb2e-a620-4a1a-a584-64c3318f9837%40googlegroups.com > > <https://groups.google.com/d/msgid/django-developers/5c96fb2e-a620-4a1a-a584-64c3318f9837%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/1686E521-D511-4750-8AEF-7087EE240660%40polytechnique.org. For more options, visit https://groups.google.com/d/optout.