On Wednesday, May 3, 2017 at 12:35:30 AM UTC+2, Marten Kenbeek wrote:
>
>  
>
>>
>>    - The more complex part is (I think) figuring out how to deal with 
>>    cases where we have a `path('/<something:int>', include(other_urls))` and 
>>    `other_urls` also has a `path()` mentioning `something`. However this 
>> might 
>>    just be my perfectionism and paranoia seeing edge-cases where there are 
>>    none, or are sufficiently "edge" cases that we can suffice with a "just 
>>    don't do it!".
>>
>>
>  The current resolver doesn't really handle this either. When resolving, 
> the current implementation simply passes on the outermost capture group to 
> the view. When reversing you can only pass in a single value that must 
> match both groups. If you can solve it, great, but I think it's sufficient 
> to let the underlying resolver handle it the same way. 
>

Yes, that's somewhat what I expected as well, just wasn't as sure. I 
*think* it's probably better to make a check that the capture groups do not 
overlap than to write code to deal with that elegantly. But that could 
probably happen in a different PR.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/427a0347-4fa9-4692-88e4-a35248e408ae%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to