I think the review comments and the Todo list should get me off to a good start. I'm sure I'll have a few questions along the way as I've contributed to other open source projects before, but not Django. I spent some time last evening reading the contribution docs and getting my environment set up.
On Jul 29, 2017 4:49 AM, "Emil Stenström" <e...@kth.se> wrote: John: Awesome! Do you need anything to get started or is Sjoerd's review comments and todolist enough? On Friday, 28 July 2017 15:03:12 UTC+2, John Griebel wrote: > Hi Sjoerd, > I too would love to see this feature in Django 2.0; in fact, I've been > following its progress quite closely. I would love to help out with it and > have the necessary time to do so. > > John Griebel | Senior Backend Engineer | 3Blades.io | 814-227-4213 > <(814)%20227-4213> > > On Thu, Jul 27, 2017 at 5:06 PM, Sjoerd Job Postmus <sjoe...@sjec.nl> > wrote: > >> Hi all, >> >> Due to scheduling, I have not been able to give this the attention I >> would like to give it, and I don't see myself freeing up a significant >> amount of time to give it the final push forward before the feature freeze >> on September 18th. >> >> I did a final review of my changes. Though there are some things that >> might need a bit of cleaning up, I have the feeling the pull request ( >> https://github.com/django/django/pull/7482) is in a reasonable state. >> There are a lot of comments by me about things that might be improved, >> though. There's also a TODO list (https://github.com/django/dja >> ngo/pull/7482#issuecomment-305482442) about things that still need doing. >> >> Based on the check-list, I think the following items remain: >> >> - Documentation the new syntax (but Tom already has a PR open for that), >> but that should only be picked up after this feature is merged/mergeable. >> - Updating existing documentation (maybe even the tutorial?) to use the >> new syntax. I think that's also included in Tom's PR. >> - Extra tests. There are dedicated tests already, but given such a core >> feature I would feel more comfortable if there were even more tests. >> - Not mentioned in the checklist, but performance concerns should also be >> checked [1]. >> >> Personally, I would love for this feature to land in Django 2.0, but I'm >> doubtful that I can push it further myself, and would be greatly >> appreciative if somebody were willing to help push it forward. >> >> [1]: Previously, the code used `LocaleRegexDescriptor`, which acted as >> `@property` when the regular expression was lazy, while if it is a pure >> string it would set the attribute directly as an optimisation trick. This >> might need to be replicated. >> >> Regards, >> Sjoerd Job >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com. >> To post to this group, send email to django-d...@googlegroups.com. >> >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit https://groups.google.com/d/ms >> gid/django-developers/d75698e7-e75e-4719-a000-4172f3ed1082% >> 40googlegroups.com >> <https://groups.google.com/d/msgid/django-developers/d75698e7-e75e-4719-a000-4172f3ed1082%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/ msgid/django-developers/12ac3285-5d09-4fe1-bbf2-b34c75150724%40googlegroups. com <https://groups.google.com/d/msgid/django-developers/12ac3285-5d09-4fe1-bbf2-b34c75150724%40googlegroups.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAOK12Wbe2XMY0WsoCApvG3tnvTLikwek%2B8LqNxc7X-HrNC2ePA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
