Hi all, Due to scheduling, I have not been able to give this the attention I would like to give it, and I don't see myself freeing up a significant amount of time to give it the final push forward before the feature freeze on September 18th.
I did a final review of my changes. Though there are some things that might need a bit of cleaning up, I have the feeling the pull request (https://github.com/django/django/pull/7482) is in a reasonable state. There are a lot of comments by me about things that might be improved, though. There's also a TODO list (https://github.com/django/django/pull/7482#issuecomment-305482442) about things that still need doing. Based on the check-list, I think the following items remain: - Documentation the new syntax (but Tom already has a PR open for that), but that should only be picked up after this feature is merged/mergeable. - Updating existing documentation (maybe even the tutorial?) to use the new syntax. I think that's also included in Tom's PR. - Extra tests. There are dedicated tests already, but given such a core feature I would feel more comfortable if there were even more tests. - Not mentioned in the checklist, but performance concerns should also be checked [1]. Personally, I would love for this feature to land in Django 2.0, but I'm doubtful that I can push it further myself, and would be greatly appreciative if somebody were willing to help push it forward. [1]: Previously, the code used `LocaleRegexDescriptor`, which acted as `@property` when the regular expression was lazy, while if it is a pure string it would set the attribute directly as an optimisation trick. This might need to be replicated. Regards, Sjoerd Job -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/d75698e7-e75e-4719-a000-4172f3ed1082%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
