[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22953#comment-22953
]
Hardy Pottinger commented on DS-1060:
-------------------------------------
I have tested the patch, and I can confirm that it appears to work as outlined
by Tim, however, I echo Mark's concern that copying *some* settings, but not
others, does not quite equal what used to happen when specifying an external
dspace.cfg file to ant update. Given that many things have happened to the
dspace.cfg (several settings have moved to their own config files), I think we
may be heading into trouble here, with a new feature that may seem to promise
more than it can deliver. The default overwrite behavior (when you do not
specify an external dspace.cfg file) works as intended, after the patch (and
that happens to be how I do things in production, keeping the config in SVN, so
we're good there). But, all concerns aside, I like the way this patch behaves,
and think there is real promise to proceeding this way. In other words, +1 to
the patch, I can live with (and can even enthusiastically embrace) the new way
our ant build file can amend dspace.cfg on the fly.
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
