[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22954#comment-22954
]
Tim Donohue edited comment on DS-1060 at 10/31/11 10:04 PM:
------------------------------------------------------------
Mark & Hardy,
Thanks for the comments.
I'm not sure if this is more along what you'd both like to see, but I just
completed testing a patch that enhances this *slightly* (see
ant-build-version2.patch)
Essentially, this new patch does the same thing as before, but now it extends
it to ALL *.properties or *.cfg files under the [dspace]/config/ directory.
So, now it not only attempts to retain settings from dspace.cfg. It also
retains your /config/modules/* settings and /config/crosswalks/* settings (and
any other *.cfg or *.properties file).
The same warnings apply however. We still cannot easily retain the following
types of settings in those files:
* Settings which are commented out by default in new version of config file
* Settings which do not (or no longer) exist in the new version of config file
* Settings which are multi-line (full value takes up multiple lines)
I've also discovered one other limitation (which exists in both of my patches).
Currently there are a number of settings which reference ${dspace.dir} (or
similar) in the dspace.cfg. These references are now lost as Ant replaces
them.
For example, this default setting:
assetstore.dir = ${dspace.dir}/assetstore
Would now be auto-replaced by Ant as:
assetstore.dir = /full/path/to/dspace/assetstore
In my mind this is an annoyance (as you can no longer just change the path of
'dspace.dir' and everything follows). But, I'm still liking this general
direction overall -- and I've yet to find a way around this.
I'm also very very aware of the fact that we are in the final days of 1.8.0.
So, I'd appreciate other's feedback here. I'm worried this 'ant update'
direction may be too "last minute".
was (Author: tdonohue):
Mark & Hardy,
Thanks for the comments.
I'm not sure if this is more along what you'd both like to see, but I just
completed testing a patch that enhances this *slightly* (see
ant-build-version2.patch)
Essentially, this new patch does the same thing as before, but now it extends
it to ALL *.properties or *.cfg files under the [dspace]/config/ directory.
So, now it not only attempts to retain settings from dspace.cfg. It also
retains your /config/modules/* settings and /config/crosswalks/* settings (and
any other *.cfg or *.properties file).
The same warnings apply however. We still cannot easily retain the following
types of settings in those files:
* Settings which are commented out by default in new dspace.cfg
* Settings which do not (or no longer) exist in the new dspace.cfg
* Settings which are multi-line (full value takes up multiple lines)
I've also discovered one other limitation (which exists in both of my patches).
Currently there are a number of settings which reference ${dspace.dir} (or
similar) in the dspace.cfg. These references are now lost as Ant replaces
them.
For example, this default setting:
assetstore.dir = ${dspace.dir}/assetstore
Would now be auto-replaced by Ant as:
assetstore.dir = /full/path/to/dspace/assetstore
In my mind this is an annoyance (as you can no longer just change the path of
'dspace.dir' and everything follows). But, I'm still liking this general
direction overall -- and I've yet to find a way around this.
I'm also very very aware of the fact that we are in the final days of 1.8.0.
So, I'd appreciate other's feedback here. I'm worried this 'ant update'
direction may be too "last minute".
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch, ant-build-version2.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
