[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22966#comment-22966
]
Tim Donohue edited comment on DS-1060 at 11/1/11 10:03 PM:
-----------------------------------------------------------
Hi Hardy,
To be clear, with the "simple" patch, I took out all attempts to retain
existing configuration settings. So, to sum up everything above, there are two
main implementation ideas going on here which we need to decide between: a
"Simple Version" (nothing flashy, but likely not controversial), or a "Retain
Configs Version" (a little bit of flashy, but may be more controversial)
(1) Simple Version (ant-build-simple.patch). When running 'ant
-Dconfig=[path-to-existing-dspace.cfg] update', this does NOT keep any of your
existing configuration settings (one exception: it keeps the value of
'dspace.dir'). Instead, it just backs up all your existing configs to *.old
files, and replaces them with a new config that has all default values. This
is similar to how things work in 1.7 if you ran the same 'ant' command in
"overwrite" mode. The only new addition is that the dspace.cfg is now treated
the same as all other configs (previously it was a special case and a
"dspace.cfg.default" file was created at times)
(2) Retain Configs Version (other two patches). When running 'ant
-Dconfig=[path-to-existing-dspace.cfg] update', these patches also attempt to
retain some of your existing configuration settings (with some exceptions as
described above). So, it still backs up your existing configs to *.old files,
but now it replaces them with a new config that retains many of your existing
settings (any settings it cannot retain go back to default values). There were
two versions of this initial patch that I had created -- 'ant-build.patch'
(which just retained existing config values in the 'dspace.cfg' file ONLY), and
'ant-build-version2.patch' (which attempted to retain existing config values in
any *.cfg or *.properties file it found under [dspace]/config/ or
subdirectories).
I hope that helps clarify the different implementations here. Again, I suspect
that the "Simple Version" is less controversial (as it keeps things mostly
"as-is", but just treats the dspace.cfg file like all our other config files).
But, I wanted to offer up the "Retain Configs Version" as an option, as it
tries to simplify the upgrade process by retaining many (but unfortunately not
all) of your existing settings.
was (Author: tdonohue):
Hi Hardy,
To be clear, with the "simple" patch, I took out all attempts to retain
existing configuration settings. So, to sum up everything above, there are two
main implementation ideas going on here which we need to decide between: a
"Simple Version" (nothing flashy, but likely not controversial), or a "Retain
Configs Version" (a little bit of flashy, but may be more controversial)
(1) Simple Version (ant-build-simple.patch). When running 'ant
-Dconfig=[path-to-existing-dspace.cfg] update', this does not keep any of your
existing configuration settings (one exception: it keeps the value of
'dspace.dir'). Instead, it just backs up all your existing configs to *.old
files, and replaces them with a new config that has all default values. This
is similar to how things work in 1.7 if you ran the same 'ant' command in
"overwrite" mode. The only new addition is that the dspace.cfg is now treated
the same as all other configs (previously it was a special case and a
"dspace.cfg.default" file was created --
(2) Retain Configs Version (other two patches). When running 'ant
-Dconfig=[path-to-existing-dspace.cfg] update', these patches also attempt to
retain some of your existing configuration settings (with some exceptions as
described above). So, it still backs up your existing configs to *.old files,
but now it replaces them with a new config that retains many of your existing
settings (any settings it cannot retain go back to default values). There were
two versions of this initial patch that I had created -- 'ant-build.patch'
(which just retained existing config values in the 'dspace.cfg' file ONLY), and
'ant-build-version2.patch' (which attempted to retain existing config values in
any *.cfg or *.properties file it found under [dspace]/config/ or
subdirectories).
I hope that helps clarify the different implementations here. Again, I suspect
that the "Simple Version" is less controversial (as it keeps things mostly
"as-is", but just treats the dspace.cfg file like all our other config files).
But, I wanted to offer up the "Retain Configs Version" as an option, as it
tries to simplify the upgrade process by retaining many (but unfortunately not
all) of your existing settings.
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch, ant-build-simple.patch,
> ant-build-version2.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
RSA® Conference 2012
Save $700 by Nov 18
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
