[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22957#comment-22957
]
Tim Donohue commented on DS-1060:
---------------------------------
Thanks for the feedback Mark,
Just as an explanation, the only reason I didn't go this route to begin with,
was that I was worried about the "copying new configuration to
config/dspace.cfg unaltered" step. If we copy that dspace.cfg in an unaltered
fashion, then by default the 'dspace.dir' path will always be set to "/dspace"
(unless we have explicit instructions to change that setting *before* you run
'ant update' -- which would be one way around that). I was trying to avoid
copying over a dspace.cfg which was actually "broken" (in that dspace.dir or
dspace.baseUrl was improperly set). But, we can just provide more explicit
instructions in our upgrade processes as needed.
It's also worth noting that this current patch actually provides two options:
* 'ant update' -> will copy the new configuration to config/dspace.cfg unaltered
* 'ant -Dconfig=[current-dspace.cfg] update' -> will attempt to retain as many
settings as it can from your "current-dspace.cfg"
So, there's a few directions we could take here:
(A) Go with a simpler route. This would likely mean that the '-Dconfig' would
just point you at the correct installation directory. Beyond that, all your
configuration files are always "reset" to default values during an upgrade.
(B) Go with the patch route. Provides an option of attempting to "merge" your
old configs with new configs. But, you can also choose to just run 'ant
update' and get all configuration files "reset" to default values.
I'll go ahead and draft up a simpler version of this patch (as described in "A"
above), so that we can quickly choose the route we'd like to take. Again, I'm
fine either way. In the building of a simpler patch, I essentially stumbled
across a way to retain many settings during a configuration upgrade (and I
wanted to make it known to others that this was possible).
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch, ant-build-version2.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
RSA® Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
