[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22981#comment-22981
]
Robin Taylor commented on DS-1060:
----------------------------------
(Emailed Tim offline in response to an earlier email from him on this subject
so I'm copying in the exchange here for others benefit)
Hi Tim,
Sorry, I'm only really just getting up to speed on this. I'm replying to this
email particularly so I can refer to it.
Actually what you describe below is what I would expect to happen. I believe
that Ant effectively does a diff between the new and old file and only creates
a .old version if there is a difference. In scenario 1 below there will
obviously be no difference so no .old file is created. Personally I like that
behaviour. When doing an update I take the creation of a .old file to mean that
something has changed and that I should investigate. Now, I guess there is a
potential problem in that if someone is actually doing a version upgrade and
follows scenario 1 then they won't get any 1.8 changes to dspace.cfg, but IMO
that is something they should realise.
So, I'll keep investigating this morning, but at the time of writing this email
I think things are fine as they are.
Cheers, Robin.
________________________________________
From: Tim Donohue [[email protected]]
Sent: 24 October 2011 21:05
To: TAYLOR Robin
Subject: Re: 1.8 update
Hi Robin,
I've just figured out what is going on.
It looks like there are two behaviors here:
(1) Run 'ant -Dconfig=[path-to-existing-dspace.cfg] update'
(2) Run 'ant update'
#1 will *NOT* generate the dspace.cfg.old file.
#2 *WILL* generate the dspace.cfg.old file.
So, it looks like there still is a minor bug here somewhere, as the
behavior should likely be the same either way.
I'll dig around, and I'll likely reopen DS-1060.
- Tim
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch, ant-build-simple.patch,
> ant-build-version2.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
