[
https://jira.duraspace.org/browse/DS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22977#comment-22977
]
Robin Taylor commented on DS-1060:
----------------------------------
Just adding some discussion from the developers meeting for info...
<robint> So if anyone has any further comment on DS-1060 please add to the Jira
issue
[20:04] <robint> I suspect Tim will want to commit any changes tomorrow
[20:05] <hpottinger> I've been testing the patches Tim has submitted for 1060,
I think all of them mark a change from the current behavior of the -Dconfig=
param
[20:05] <robint> Just saw your latest comment
[20:07] <hpottinger> the simple patch will likely be the least controversial,
as Tim says
[20:07] <robint> I can't even make up my mind what the optimum behaviour should
be
[20:08] <robint> Without Tim I'm not sure how much we can do here so possibly
best just to keep adding commentss to the issue.
[20:09] <hpottinger> I believe certain development workflows count on being
able to pass in a custom-tweaked dspace.cfg
[20:09] <robint> Ok, should we move on to documentation ?
[20:09] <robint> Sorry hpottinger, I'll slow down :)
[20:09] <mhwood> I rather don't like the idea of hunting for settings that
didn't get copied. Especially since what sites *should* do is to customize a
copy of the new stock config from their old settings *before* running 'ant
-Dconfig=newone update'.
[20:10] <robint> mhwood: thats my preference too
[20:11] <mhwood> Maybe copy-as-many-settings-as-we-can should be a separate
target.
[20:12] <hpottinger> I like that
[20:13] <robint> Yes I worry its becoming too messy by trying to be too
intelligent
[20:13] <mhwood> Anyway, whether the source of the configuration is specified
explicitly or defaults to the source kit, IMHO update should do the same thing.
My preference would be "just move the old one aside and copy it".
[20:14] <robint> +1
[20:14] <mhwood> ("It" is the source of the config. file, not the old config.)
[20:15] <hpottinger> +1
> When running 'ant update' copy dspace.cfg to *.old in line with all the other
> config files
> ------------------------------------------------------------------------------------------
>
> Key: DS-1060
> URL: https://jira.duraspace.org/browse/DS-1060
> Project: DSpace
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Robin Taylor
> Assignee: Tim Donohue
> Fix For: 1.8.0
>
> Attachments: ant-build.patch, ant-build-simple.patch,
> ant-build-version2.patch
>
>
> Ant target overwrite_configs contains the following line...
> <globmapper from="*" to="*-${build.date}.old" />
> Whereas target prepare_configs contains the following line...
> <globmapper from="*" to="*.default" />
> It may be just a case of bringing prepare_configs in line with
> overwrite_configs but I haven't had a chance to analyse this properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
