> Selon Benoit Audouard <[EMAIL PROTECTED]>:
>
>> Le vendredi 05 novembre 2004 à 02:02 +0100, [EMAIL PROTECTED] a écrit :
>> > About last modifications in eagleusb/utils/scripts/eu_config_bash
>> >
>> > Some ISP are repeated many times (with different ISP_NAME) :
>> > - "ES01" 5 times,
>> > - "ES02" 3 times,
>> > - "IT01" 3 times,
>> > - "UK01" 2 times.
>> yep, they have the same config VPI / VCI / encapsulation. We can still
>> choose a different number (I've not yet finished the list...)
>
> If we factorized ISP with the same configuration, then I prefer this
> "xBE01" ) VPI="08" ; VCI="23"; ENC="06"; COUNTRY="Belgique";
> ISP_NAME="Belgacom, Tiscali.be"
> ;;
The limit of this is the length to display the list
> Because with this code, the second case is never executed
> (always ISP_NAME != "Wanadoo PPPoE")
> "xES01" ) VPI="08"; VCI="20"; ENC="01"; COUNTRY="España";
> ISP_NAME="Telefonica IP dinamica" ;;
> "xES01" ) VPI="08"; VCI="20"; ENC="01"; COUNTRY="España";
> ISP_NAME="Wanadoo PPPoE" ;;
arg, indeed, you are right.
I always see this as a list, when it's in fact used in the following loop :
for ISP_TMP in AR01 AT01 BE01 BE02 BE03 BR01 BR02 BR03 BR04 BG01 BG02 DK01
DE01 ES01 ES02 ES03 ES04 FI01 FR01 FR02 FR03 FR04 FR05 FR06 FR07 GR01 HU01
IE01 IT01 IT02 IT03 LT01 MA01 NL01 PL01 PT01 SE01 CH01 CH02 TH01 UK01 ; do
get_gata_from_isp $ISP_TMP
COUNTRY="$COUNTRY " ; COUNTRY=${COUNTRY:0:11}
ISP_NAME="$ISP_NAME " ; ISP_NAME=${ISP_NAME:0:23}
echo "$ISP_TMP : $COUNTRY $ISP_NAME $VPI $VCI $ENC $PROTOC"
done
(see
http://cvs.gna.org/viewcvs/eagleusb/eagleusb/utils/scripts/eu_config_bash?rev=1.17&sortby=date&content-type=text/vnd.viewcvs-markup
)
ahlala, I've got some modifications to do, ok for the moment I'll change
numbers (thanks mcoolive for double-checking what I do ;-) )
The problem I see is that users may focus on "is my ISP in the list ?"
whereas the only important thing is "are my parameters for VPI / VCI /
encapsulation available ?" => I've already had this remark at least once.
The whole list is unmaintainable anyway (I once saw a list of chinese ISP,
there were more than 20 listed !). The important thing is *really* that
once eagle-usb.conf configured, it's sufficient to make all scripts and
driver work correctly.
>> yep, they have the same config VPI / VCI / encapsulation.
> But Communitel :-)
> "xES01" ) VPI="00"; VCI="21"; ENC="06"; COUNTRY="España";
> ISP_NAME="Communitel" ;;
Thanksfully, it was only a first implementation as I had in mind to work
again on it (I was quite sure that I would be making errors, at least
typo, that's worse I had anticipated though :'-( ).
@++
Ben'. aka baud123
