On 03/18/16 22:13, David Woodhouse wrote:
> On Fri, 2016-03-18 at 20:02 +0100, Laszlo Ersek wrote:
>> On 03/18/16 19:40, David Woodhouse wrote:
>>
>>>
>>> But this is different. This is the commit messages. And what would you
>>> know... the last commit message in the log which isn't ASCII *isn't*
>>> that other one I pointed out; it's one from you (7daf2401) in which you
>>> commit the heinous crime of slepping Michał Zegan's name correctly :)
>> I went to extreme lengths to commit his name correctly. It wasn't at all
>> natural for me. But names are names.
>>
>>>
>>> No, I genuinely don't know of any reason to eschew non-ASCII characters
>>> in commit messages.
>
>> Because they are a PITA for people who don't use UTF-8 generally? (I
>> don't.)
>
> This doesn't really make sense at any level. You must have to jump
> through hoops to still operate a legacy 20th-century character set on a
> modern Linux distribution, surely?
Not too many. Good locale support and good internationalization means
that my ISO8859-2 preference is well accommodated.
> And it must confer *no* benefit to
> you
It certainly does. It allows me to use my text editor of choice. I've
been using that editor for ~15 years, and in the last five years, it's
been running 10 hours per day or more.
> — unless you count it as a benefit that you have to go to 'extreme
> lengths' just to get someone's *name* right — something that normally
> ought to Just Work™ when you use 'git am'.
>
> And once it's been committed, either your system just doesn't display
> the commit logs correctly at all (and gets names like Michał's wrong),
> or you shouldn't even *notice* the emdash. Which is it?
It happens to display Michał's name correctly, because it fits in latin2.
[i18n]
logOutputEncoding = latin2
commitencoding = latin2
The extreme lengths that I had to go to were necessary to convince
git-send-email not to mess up Michał's CC in the email headers, picking
it up from the commit message. The commit message was all right, but the
email header got mis-encoded (it's a git bug; it thought the CC line was
UTF-8, despite knowing that the full commit message was latin2).
emdash doesn't display correctly for me indeed, in the output of "git
log". It's not a big annoyance, but if I am to apply a patch, I try to
prevent it.
> I strongly suspect the latter, and that you only noticed because you
> were looking closely at the encoding because of that Evolution bug?
No. I tend to notice glyphs by the naked eye that are not ascii / latin1
/ latin2. Here's another example:
http://thread.gmane.org/gmane.comp.bios.edk2.devel/8563/focus=8566
>> Anyway, we won't convince each other; we've been through this. Feel free
>> to post non-ASCII in the commit messages; should I come across them,
>> I'll try to fix them up (except in names).
>
> No. Please don't. If this was another of the bizarre but enforced-by-
> the-project things then I was prepared to tolerate it until it could be
> fixed, but if you are just mangling my commit messages to make them
> less grammatically correct for an unsupportable personal preference,
> then that's not OK.
>
> The correct character to use in that situation is the emdash, If you
> *absolutely* must, then rewrite the whole sentence to avoid using it.
> Do *not* replace it with hyphens.
Okay. I've googled the use of emdash in the English language, and it
seems to be more or less interchangeable with parens. Is that okay?
> And when you do tweak a commit
> message, it is best practice to *note* that you have done so, and why.
Absolutely.
> Rewriting it for this reason is *not* acceptable.
Fine. Please ask Jordan to apply the patch then.
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
