On Tue, 2016-03-08 at 15:20 +0100, Laszlo Ersek wrote: > + UINT64 PciExBarBase; ... > if (mHostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) { ... > + PciExBarBase = FixedPcdGet64 (PcdPciExpressBaseAddress); ... > } ... > if (mHostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) { ... > + AddReservedMemoryBaseSizeHob (PciExBarBase, SIZE_256MB, FALSE);
The mHostBridgeDevId variable is global. Therefore as far as the compiler knows, it can change between those two if() statements. VS2008 complains thus: e:\edk2\ovmfpkg\platformpei\platform.c(275) : warning C4701: potentially uninitialized local variable 'PciExBarBase' used If only we had some kind of code submission process where your submission could be automatically subjected to build tests on all platforms, and the status of those builds could be automatically displayed right there with your request... :) -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel