On Fri, 2016-03-18 at 19:05 +0100, Laszlo Ersek wrote: > On 03/18/16 18:45, David Woodhouse wrote: > > > > On Fri, 2016-03-18 at 17:53 +0100, Laszlo Ersek wrote: > > > > > > > > > (1) The commit message uses at least one non-ASCII character, the EM > > > DASH (U+2014). Can you please replace it with a "--"? Yes, I know you > > > hate me for asking this. Please just write me off as stupid and replace > > > the character. > > No. This isn't 1994. > Really? I wouldn't know. If I look at what ISO C features we're allowed > to use, we certainly seem to be stuck in 1995. Or, well, sometime before > 1989, because we can't even use structure assignment.
That's a separate issue. Yes, we still insist on supporting the Microsoft toolchains despite the fact that they are so badly maintained that they don't even support the last C standard of the *previous* century, let alone anything from the 2000s. But this is different. This is the commit messages. And what would you know... the last commit message in the log which isn't ASCII *isn't* that other one I pointed out; it's one from you (7daf2401) in which you commit the heinous crime of slepping Michał Zegan's name correctly :) > There is a good reason. You know it and you don't care about it. Not a > problem; I'll fix up the commit message. No, I genuinely don't know of any reason to eschew non-ASCII characters in commit messages. > > Er, really? What insanity is this? > > Please ask your colleagues at Intel (but please also make sure that you > don't take offense on their behalf, when you call their guidelines > insane ;) ). Hehehe. Touché. > > > > Where did these guidelines come from > > and can they be fixed? Why would initialisation of local variables > > *ever* be frowned upon? How do they make this stuff up? > Please consult "EDK II C Coding Standards Specification.pdf", section > 6.8 "C Function Layout": > > *Initializing a variable as part of its declaration is illegal.* > > (Emphasis theirs.) Insanity theirs :) Why in $DEITY's name would anyone write this? Was it done for a bet? > \o/ > > Finally something I'm not held responsible for! > > (BTW, why did you mail out the patch with Evolution, rather than > git-send-email? Are you sure you are using the tools as they were > intended? :)) :) I like to have copies in my sent-mail folder of everything I sent. It also gets S/MIME signatures, and it's easier to hit 'reply' and have a properly-threaded message, rather than having to extract the Message-Id of the message I want to reply to and feed it to git-format-patch. On the whole (modulo evo bugs) it's easier just to insert the plain text file into the email I'm sending, for a single patch at least. And I seem to have got away without triggering that Evo bug for a long time, by working on code which cares more about messy trailing whitespace on lines, than it does about other things :) -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
