Hi, Ok, thank you for testing and comments. I added descriptions to gcode.html and g-code.txt. Is that ok? Also how to add tests for these G-codes? Updated .diff is uploaded to http://personal.inet.fi/koti/ekasorvaus/linuxcnc/g84_g74.diff
-- Tero Kaarlela Production Engineer Eka-Sorvaus OY Nivala Finland ----Alkuperäinen viesti---- Lähettäjä : s...@highlab.com Pvm : 03/11/2016 - 22:17 (EET) Vastaanottaja : tero.kaarl...@eka-sorvaus.fi, emc-developers@lists.sourceforge.net Aihe : Re: [Emc-developers] Adding G84/G74 floating tapping cycles On 11/03/2016 11:59 AM, tero.kaarl...@eka-sorvaus.fi wrote: > Ok, > > I added saving previous state of Speed and Feed override enable. And > restore after cycle is done. I am not sure if this is correct way of > implementing this? It has been tested and does work. Also updated for > current master. Could someone check this and tell me if it is usable > or not. > > http://personal.inet.fi/koti/ekasorvaus/linuxcnc/g84_g74.diff Thanks for working on this! I tested your patch with the current tip of the master branch, and though it compiles, many of the tests in our test suite fail. The failures look relatively minor. Also, i see that there is no test of the new G-codes, and no documentation. -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
