On Fri, Sep 23, 2016 at 09:50:32PM +0300, [email protected] wrote: > Hi, > > It seems I was wrong. DISABLE_SPEED_OVERRIDE and > DISABLE_FEED_HOLD do work. Using halmeter for pin > motion.spindle-speed-out confirmed correct behaviour. Also > Feed_hold_disable works but it was not what I was looking for. > I was hoping to disable halui.program.pause during G84 cycle. > How should I implement that? Also G74 and G84 are now in same > function "int Interp::convert_cycle_g74_g84" because despite > rotation directions behaviour is same. Is this good way to do > this or should I separate both to own functions for clarity? >
Hi Tero, Andy P shared your patch http://personal.inet.fi/koti/ekasorvaus/linuxcnc/g84_g74.diff on irc and I have not tried it but I have a little feedback for you. First, thanks for working on this! People have requested these cycles before. If you'd like to update the documentation to include this feature, the places to edit would be docs/html/gcode.html for the quickref, and then docs/src/gcode/g-code.txt The docs for these cycles are a little more complicated than the existing ones because (I think?) the expected pitch comes from the interaction between F and S. The very old docs of EMC(1) included some description of G84 - you can see that at https://www.nist.gov/customcf/get_pdf.cfm?pub_id=823374 This might be a starting point but it's incomplete - I see your patch uses the P word somehow but the old docs don't describe that. By inspection (untested) I think I see a small bug with your current patch: if you have feed or speed overrides already disabled before this cycle using M49, calling G84 will erroneously reenable the override. To answer your questions: Having the g74 and g84 implementations shared except for the minor difference of cw/ccw is very good - certainly don't split them apart. Without digging I don't know how to disable program pause during parts of the cycle, but I think g76 and g33/g33.1 do this, and maybe you could (first check that it still works and) study those. The changes to spindle-at-speed handling are extensive, and I'm afraid we probably don't have good (or any) test coverage for that. Maybe someone can help? Again, thank you! Chris ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
