>What test are you doing that shows it not working? I added these to interp_cycles:
prev_state_fovr = GET_EXTERNAL_FEED_OVERRIDE_ENABLE(); prev_state_sovr = GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE(); printf("interp fo: %d\n",prev_state_fovr); printf("interp so: %d\n",prev_state_sovr); And these print: interp fo: 1 interp so: 1 With M48 and M49 Also M48/M49 does not affect: if(prev_state_fovr) ENABLE_FEED_OVERRIDE(); -- Tero Kaarlela Production Engineer Eka-Sorvaus OY Nivala Finland ----Alkuperäinen viesti---- Lähettäjä : ch...@timeguy.com Pvm : 01/10/2016 - 23:41 (EEST) Vastaanottaja : tero.kaarl...@eka-sorvaus.fi, emc-developers@lists.sourceforge.net Aihe : Re: [Emc-developers] Adding G84/G74 floating tapping cycles On Sat, Oct 01, 2016 at 10:59:54PM +0300, tero.kaarl...@eka-sorvaus.fi wrote: > > GET_EXTERNAL_FEED_OVERRIDE_ENABLE() > GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE() > Always return 1. I am afraid. Maybe because in saicanon.cc we have: > > /* MGS - FIXME - These functions should not be stubbed out to return > constants. > They should return variable values... */ > int GET_EXTERNAL_FEED_OVERRIDE_ENABLE() {return 1;} > int GET_EXTERNAL_SPINDLE_OVERRIDE_ENABLE() {return 1;} > > So this needs to be fixed first? Hi Tero, You are in a maze of twisty little passages, all alike. SAI is the "stand-alone interpreter" which is mostly used by the test suite - it's not used by a running linuxcnc at all. Some of the things the test suite don't care about are not implemented, including this -- just as some things aren't implemented for the AXIS preview when it doesn't make any difference for preview (in src/emc/rs274ngc/gcodemodule.cc you'll find another return 1 for this function.) The important definition for the motion controller is in src/emc/task/emccanon.cc: int GET_EXTERNAL_FEED_OVERRIDE_ENABLE() { return emcStatus->motion.traj.feed_override_enabled; } I think it's likely it does actually work, because I can see the status buffer gets changed by doing this test: Run sim/axis Home all axes Machine/Show LinuxCNC Status scroll down to feed_override_enabled MDI m48, m49 See that feed_override_enabled changes What test are you doing that shows it not working? Chris ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers