Alon Bar-Lev has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27647/14/Makefile File Makefile: Line 146: -e "s|@ENGINE_CACHE@|$(PKG_CACHE_DIR)|g" \ Line 147: -e "s|@ENGINE_PID@|$(PID_DIR)/$(ENGINE_NAME).pid|g" \ Line 148: -e "s|@SETUP_LOG@|$(PKG_LOG_DIR)|g" \ Line 149: -e "s|@SETUP_USR@|$(DATA_DIR)|g" \ Line 150: -e "s|@SETUP_VAR@|$(PKG_STATE_DIR)|g" \ > I kept is this way just because I think that it's better to change the valu we already have ovirt-engine-setup-base Line 151: -e "s|@DEV_PYTHON_DIR@|$(DEV_PYTHON_DIR)|g" \ Line 152: -e "s|@RPM_VERSION@|$(RPM_VERSION)|g" \ Line 153: -e "s|@RPM_RELEASE@|$(RPM_RELEASE)|g" \ Line 154: -e "s|@PACKAGE_NAME@|$(PACKAGE_NAME)|g" \ -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
