Alona Kaplan has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 97: protected void doEdit(ClusterGeneralModel model) {
Line 98: Driver.driver.edit(model);
Line 99: }
Line 100:
Line 101: private class FormItemWithDefaultValue extends FormItem {
Why is this an inner class? Move it to a separate file so it can be used from
other places.
Line 102: private TextBoxLabel defaultValue;
Line 103: private Condition condition;
Line 104:
Line 105: public FormItemWithDefaultValue(String name,
Line 118: return condition.isTrue() ? super.getValue() :
defaultValue;
Line 119: }
Line 120: }
Line 121:
Line 122: private interface Condition {
I know I told you to use an interface. But now that I see it again I realize it
can be substituted with a boolean value.
Line 123: boolean isTrue();
Line 124: }
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
