Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 101: @Override
Line 102: public Widget getValue() {
Line 103: return
getModel().getEntity().supportsGlusterService() ? noOfVolumesDown
Line 104: : new
TextBoxLabel(constants.notAvailableLabel());
Line 105: }
Ok. But only the relevant fields should be shown if the application is not
running in dual mode(Application mode is VirtOnly or GlusterOnly).
you can do ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly) for
virt fields and
ApplicationModeHelper.isModeSupported(ApplicationMode.GlusterOnly) for gluster
fields to make them visible/invisible in relevant modes. For example the virt
fields should be shown if the application mode is VirtOnly or AllModes.
Line 106: });
Line 107: }
Line 108:
Line 109: @Override
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
