On Friday 28 April 2006 17:18, Jeremias Maerki wrote: > Good stuff! Big thanks to Pete, Joe and Manuel for your work on the > AFP Renderer and for enduring the ASF bureaucracy. > > Some initial comments on the code: > - I've already mentioned the tab characters to Manuel. He's looking > into them shortly. Yes, will to later today. > - We should change the namespace declaration in AFPExtensionMapping > to match the pattern we started with ExtensionElementMapping and > PSExtensionElementMapping, i.e. > http://org.apache.fop/extensions/afp --> > http://xmlgraphics.apache.org/fop/extensions/afp Shouldn't be a problem - will do. > - I think the META-INF entry for the above ExtensionMapping is > missing. Will look into it - BTW, your new support for non FO namespace attributes sounds very appealing for use in the AFP renderer. > - We now > have two SVGConverter classes (RTF and AFP). Furthermore, I have > similar functionality in PCLSVGHandler. Maybe this can be > consolidated a little. > - I may look into creating a Graphics2DAdapter for AFP as I have done > for PCL. That enables to bypass SVG/Batik for FOP extensions which > support painting to Java2D directly. It may even be possible to > change the PCLSVGHandler in a way that it can serve as base class for > other SVGHandlers which convert SVG into bitmaps (obviously after a > rename/move). Good idea. > <snip/> > > Manuel > > Jeremias Maerki
Manuel
