That all sounds good. As for the extension vs. Config approach, the config could specify the default behavior & users could override it via individual fox:image-missing-behavior (or fox:fail-on-missing-image or something). If there's no @fox:[image-missing-behavior] specified, it'll do the config setting or log a warning if nothing specified.
Clay On 2/17/08, Jeremias Maerki <[EMAIL PROTECTED]> wrote: > Thanks for the hint. I'll look into it. > > On 16.02.2008 14:09:27 Andreas Delmelle wrote: > > > > Hi all > > > > Reason for this question is I'm trying out a test-suite that was > > shared by Kumar Puppala (see a recent thread on fop-users). > > > > The image formats are the same (PNG), and they are never present. > > > > Mostly, when the images are not available, I simply see an error in > > the log, but the process continues nevertheless, and simply yields a > > result that does not include the image. > > Apparently, though, for some images, the formatting process crashes > > with a FileNotFoundException for the very same reason. > > (in xmlgraphics.image.loader.cache.ImageCache.needImageInfo(), when > > the cache is accessed through the ImageManager, from > > fop.render.pdf.PDFRenderer.putImage()) > > > > AFAICT, this is caused by the width/height and content-width/content- > > height properties being explicitly specified (leads to the FNFE). If > > they revert to their initial values, the renderer is able to continue > > without having to open the file. > > > > So, small question: > > Wouldn't it be possible and cleaner to make the behavior more > > consistent? Either crash or continue with an error-message in the > > log, for all absent images, but not depending on whether the user > > specified explicit values for the image dimensions? > > > > Just wondering. Not that I have a strong preference in either > > direction, but I just thought it might confuse our users if they see > > FOP recover from the error in one case, and crash in others... > > > > > > Cheers > > > > Andreas > > > > > Jeremias Maerki > > -- Sent from Gmail for mobile | mobile.google.com Regards, The Web Maestro -- <[EMAIL PROTECTED]> - <http://homepage.mac.com/webmaestro/> My religion is simple. My religion is kindness. - HH The 14th Dalai Lama of Tibet
