Yes, there is are good reasons to continue using findbugs:

(1) it does find bugs
(2) they should not be added the exclude file without careful evaluation
(3) when evaluating, real bugs should be fixed; however, there are some
cases where findbugs reports a warning or error that is in fact not a bug,
but is intended to be that way by design; for example, returning a null vs
returning an empty array: findbugs will report the former as a warning, but
some designs may prefer that route;

Any exclusions added to the findbugs-exclude file should be done carefully
and after explicit evaluation.

I know that has not been the case recently, due to lack of time, and some
exclusions have been added without evaluation. This should be avoided, and
any exclusions added automatically should be marked as such for further
evaluation and repair.

G.

On Mon, Feb 21, 2011 at 11:15 AM, Vincent Hennebert <vhenneb...@gmail.com>wrote:

> Hi,
>
> If we solve issues raised by FindBugs by listing them in an ignore file,
> is there still a point to use FindBugs at all?
>
> It seems to me that some of those issues deserve to be fixed. They seem
> to point out genuine problems in the code.
>
> Vincent
>
>
> On 18/02/11 08:18, spepp...@apache.org wrote:
> > Author: spepping
> > Date: Fri Feb 18 08:18:04 2011
> > New Revision: 1071912
> >
> > URL: http://svn.apache.org/viewvc?rev=1071912&view=rev
> > Log:
> > Fixing checkstyle errors and hiding fingbugs errors
> >
> > Modified:
> >     xmlgraphics/fop/trunk/findbugs-exclude.xml
> >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
> >
> > Modified: xmlgraphics/fop/trunk/findbugs-exclude.xml
> > URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/findbugs-exclude.xml?rev=1071912&r1=1071911&r2=1071912&view=diff
> >
> ==============================================================================
> > --- xmlgraphics/fop/trunk/findbugs-exclude.xml (original)
> > +++ xmlgraphics/fop/trunk/findbugs-exclude.xml Fri Feb 18 08:18:04 2011
> > @@ -5019,4 +5019,51 @@
> >        <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
> >     </Match>
> >     <!-- /Automatically generated list of exclusions -->
> > +   <!-- Automatically generated list of exclusions on 18 February 2011
> -->
> > +   <Match>
> > +      <Class name="org.apache.fop.afp.goca.GraphicsSetProcessColor"/>
> > +      <Method name="writeToStream"/>
> > +      <Bug pattern="OS_OPEN_STREAM"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.pdf.PDFFactory"/>
> > +      <Method name="makeSeparationColorSpace"/>
> > +      <Bug pattern="DM_FP_NUMBER_CTOR"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.pdf.PDFFactory"/>
> > +      <Method name="toColorVector"/>
> > +      <Bug pattern="DM_FP_NUMBER_CTOR"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.fo.expr.PropertyTokenizer"/>
> > +      <Field name="recognizeOperator"/>
> > +      <Bug pattern="URF_UNREAD_FIELD"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.layoutmgr.BlockLayoutManager"/>
> > +      <Method name="getNextChildElements"/>
> > +      <Bug pattern="BC_UNCONFIRMED_CAST"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.util.ColorWithFallback"/>
> > +      <!-- Listing the method 'equals' does not work -->
> > +      <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.util.ColorWithFallback"/>
> > +      <Method name="getAlternativeColors"/>
> > +      <Bug pattern="PZLA_PREFER_ZERO_LENGTH_ARRAYS"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.fo.expr.NamedColorFunction"/>
> > +      <Method name="eval"/>
> > +      <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
> > +   </Match>
> > +   <Match>
> > +      <Class name="org.apache.fop.util.ColorUtil"/>
> > +      <Method name="parseAsFopRgbNamedColor"/>
> > +      <Bug pattern="REC_CATCH_EXCEPTION"/>
> > +   </Match>
> > +   <!-- /Automatically generated list of exclusions on 18 February 2011
> -->
> >  </FindBugsFilter>
> > \ No newline at end of file
> >
> > Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
> > URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java?rev=1071912&r1=1071911&r2=1071912&view=diff
> >
> ==============================================================================
> > ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
> (original)
> > +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java
> Fri Feb 18 08:18:04 2011
> > @@ -60,7 +60,8 @@ public class PDFImageHandlerSVG implemen
> >      private static Log log =
> LogFactory.getLog(PDFImageHandlerSVG.class);
> >
> >      /** {@inheritDoc} */
> > -    public void handleImage(RenderingContext context, Image image,
> Rectangle pos)
> > +    public void handleImage(RenderingContext context,                //
> CSOK: MethodLength
> > +                            Image image, Rectangle pos)
> >                  throws IOException {
> >          PDFRenderingContext pdfContext = (PDFRenderingContext)context;
> >          PDFContentGenerator generator = pdfContext.getGenerator();
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: fop-commits-unsubscr...@xmlgraphics.apache.org
> > For additional commands, e-mail: fop-commits-h...@xmlgraphics.apache.org
> >
>

Reply via email to