Le 1 nov. 2013 02:05, "Andy Bradford" <[email protected]> a écrit : > > Thus said =?Big5?B?vEKq2qtG?= on Fri, 01 Nov 2013 13:55:50 +0800: > > > Great thanks, I was just wondering about that. I tried the fix and > > works well for me, it now prompts for remembering password when > > cloning with username+password. > > As it turns out, after I committed the fix, I discovered another case in > which it doesn't behave as one might expect: > > Before the patch it would not use the password in the URL and so it > would fail: > > $ fossil sync --once http://tester:testing@localhost:8081/ > Round-trips: 1 Artifacts sent: 0 received: 0 > Error: login failed > password for tester: > > Now it recognizes that there is one there, but it still fails: > > $ fossil sync --once http://tester:testing@localhost:8081/ > remember password (Y/n)? y > Round-trips: 1 Artifacts sent: 0 received: 0 > Error: login failed > password for tester: > > Arguably it should not prompt to save the password if --once is > specified. > > Seems the complete fix may not be as straightforward as I initially > thought. >
Personally, I think it shouldn't prompt to save password when specifying it from URL. When using a interactive shell, it's better to let fossil prompt for the password, then it's time to ask to save it. When I specify password from URL, it's because I don't want to be prompt for it, so it might be the same for the 'save password' prompt. When is it needed to specify it on the URL? When writing script which might run in background. In that case we don't want any prompt. It's just my 2 cents... Regards -- Martin G.
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
