On Wed, May 29, 2002 at 01:07:01PM -0700, Matthew Dillon wrote: > :On Wed, May 29, 2002 at 11:26:26AM -0700, Julian Elischer wrote: > :> > > :> > 9) More gratuitous braces as well as gratuituos ()'s and white space > :> > changes in ithread_schedule() obfuscate the functional diffs. > :> > :> I guess so though it made it a hell of a lot more readable to me. > : > :That isn't the issue. You have posted a diff that you plan to commit in > :an implied one-shot event. If you really have(want) to make these style > :changes, please commit them, and them alone right now. That will remove > :them from this patch and make jhb an Co'.s life easier. > > No hold on a minute. Some of us believe that adding those extra > braces and parenthesis makes the code a whole lot more readable. they > are NOT gratuitous in the least, certainly not from my point of view!
Uh... Matt where did I say they were. I requested that they be committed separately from functionality. And if they were going to be committed, for it to happen now. That is all I said -- nothing more. I held me tongue on the "gratuitous" issue and the fact that Julian has a long history of breaking existing style in his commits. > Furthermore, it is an extreme and inappropriate imposition on Julian > to require that he extract all the alleged 'gratuitous braces and > ()'s)' into a separate commit. Uh, no it isn't. That is the rules we operate under. This type of request comes up _daily_, and is generally agreed upon by most committers. Sorry, but the work involved is just part of making commits. > I will say quite bluntly that in the vast majority of cases on these > lists where I've seen someone ask for whitespace fixes to be committed > separately, I have yet to see any significant (or any at all!) developers > take advantage of the separate commits when incorporating the work into > their own development trees. I personally do look at diffs using -r <before_commit> -r <with_WS_only> followed by -r <with_WS_only> -r <with_functionality_only> Should I start sending an email to -current every time I do so that you will know that someone does? To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message