<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39831 >
This transaction appears to have no content
Hi, When I started playing Freeciv, the sentence in the documentation that puzzled me most was "May become veteran through training or combat". Combat was clear, but I kept looking for ways to train my units *after* they had been built. Laugh at me if you want, but it took me a while to figure out that the training was supposed to take place in the Barracks while the units were built. So I have written a small modification to helpdata.c to improve this sentence: - for terrestrial units, it will show: "May become veteran through combat or training (if built in a city with Barracks or in a civilization with an active Sun Tzu.)" - for maritime units, it will show: "May become veteran through combat or training (if built in a city with Port Facility.)" - for planes and helicopters, the message will be: "May become veteran through combat or training (if built in a city with Airport.)" There are three exceptions, though: Triremes can't be built if you have Port Facility, because Navigation obsoletes them. However, they may become veteran if they survive in the high seas, so the message could say: "May become veteran through combat or training (if it survives in the high seas.)"; the other exceptions are Diplomats and Spies. They are too high-brow to attend Barracks, but Communist governments make them veteran, so the message is: "May become veteran through combat or training (if built under a communist government.)" These are the special cases I have thought of. Perhaps rulesets can be twisted to make Port Facilities without Navigation, but I really think this new messages would help newbies. I don't especially like the wording. Feel free to change it. As for the online manual, the mentions to Barracks, Sun Tzu and the like could link to the proper pages. I can update it once we have a final version. The diff file is for trunk/client/helpdata.c Cheers, JoanHi,
When I started playing Freeciv, the sentence in the documentation that puzzled me most was "May become veteran through training or combat". Combat was clear, but I kept looking for ways to train my units *after* they had been built. Laugh at me if you want, but it took me a while to figure out that the training was supposed to take place in the Barracks while the units were built.
So I have written a small modification to helpdata.c to improve this sentence:
- for terrestrial units, it will show: "May become veteran through combat or training (if built in a city with Barracks or in a civilization with an active Sun Tzu.)"
- for maritime units, it will show: "May become veteran through combat or training (if built in a city with Port Facility.)"
- for planes and helicopters, the message will be: "May become veteran through combat or training (if built in a city with Airport.)"
There are three exceptions, though: Triremes can't be built if you have Port Facility, because Navigation obsoletes them. However, they may become veteran if they survive in the high seas, so the message could say: "May become veteran through combat or training (if it survives in the high seas.)"; the other exceptions are Diplomats and Spies. They are too high-brow to attend Barracks, but Communist governments make them veteran, so the message is: "May become veteran through combat or training (if built under a
communist government.)"
These are the special cases I have thought of. Perhaps rulesets can be twisted to make Port Facilities without Navigation, but I really think this new messages would help newbies.
I don't especially like the wording. Feel free to change it.
As for the online manual, the mentions to Barracks, Sun Tzu and the like could link to the proper pages. I can update it once we have a final version.
The diff file is for trunk/client/helpdata.c
Cheers,
Joan
Index: helpdata.c
===================================================================
--- helpdata.c (revision 13910)
+++ helpdata.c (working copy)
@@ -1010,8 +1010,34 @@
sprintf(buf + strlen(buf),
_("* Will never achieve veteran status.\n"));
} else {
- sprintf(buf + strlen(buf),
- _("* May become veteran through training or combat.\n"));
+ switch(utype_move_type(utype)) {
+ case AIR_MOVING:
+ case HELI_MOVING:
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training (if built in a city with Airport.)\n"));
+ break;
+ case LAND_MOVING:
+ if (utype_has_flag(utype, F_DIPLOMAT)||utype_has_flag(utype, F_SPY)) {
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training (if built under a communist government.)\n"));
+ } else {
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training (if built in a city with Barracks or in a civilization with an active Sun Tzu.)\n"));
+ }
+ break;
+ case SEA_MOVING:
+ if (utype_has_flag(utype, F_TRIREME)) {
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training (if it survives in the high seas.)\n"));
+ } else {
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training (if built in a city with Port Facility.)\n"));
+ }
+ break;
+ default: /* should never happen in default rulesets */
+ sprintf(buf + strlen(buf),
+ _("* May become veteran through combat or training\n"));
+ }
}
if (utype_has_flag(utype, F_TRIREME)) {
sprintf(buf + strlen(buf),
_______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
