Follow-up Comment #2, patch #3835 (project freeciv):
Backport patches attached. Looking through them, I wonder if the
local_reqs_of_type[] checks in S2_4 and trunk should be wrapped in a
conditional like the reqs_of_type[] checks that follow. In the absence of
such a conditional, it is potentially possible (depending on the ordering of
individual requirements in the requirements_vector) that one of these might be
triggered for a negated requirement (or am I reading the code wrong?). S2_3
needs no such adjustment, as it doesn't contain that class of check.
(file #17699, file #17700)
_______________________________________________________
Additional Item Attachment:
File name: negated-requiement-sanity.S2_3.patch Size:3 KB
File name: negated-requiement-sanity.S2_4.patch Size:3 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3835>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
