Follow-up Comment #3, patch #3835 (project freeciv): > I wonder if the local_reqs_of_type checks in S2_4 and trunk > should be wrapped in a conditional like the reqs_of_type > checks that follow. In the absence of such a conditional, it is > potentially possible (depending on the ordering of individual > requirements in the requirements_vector) that one of these might > be triggered for a negated requirement (or am I reading the code > wrong?).
Yes, "not oceanic" + "not desert" + "not jungle" requirements make sense, as well as "oceanic" + "not lake". On the other hand in "desert" + "not oceanic", latter is redundant (but it's acceptable if code accepts that case - we're more worried about false rejections here). _______________________________________________________ Reply to this item at: <http://gna.org/patch/?3835> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freecivfirstname.lastname@example.org https://mail.gna.org/listinfo/freeciv-dev