On 05/12/2015 06:47 PM, Alexander Bokovoy wrote:
On Tue, 12 May 2015, Petr Vobornik wrote:
On 05/12/2015 11:22 AM, Alexander Bokovoy wrote:
On Tue, 12 May 2015, Martin Babinsky wrote:
%attr(644,root,root) %{_unitdir}/ipa-ods-exporter.service
+%attr(644,root,root) %{etc_systemd_dir}/httpd.service
There is a minor issue: a lack of

Requires: /etc/systemd/system

which is needed because of /etc/systemd/system directory owned by a
different package. We require systemd-units which is provided by
package as well so it is sort of mitigated by that but it would
good to be explicit in the require. And yes, you can require the
directory because systemd provides it:

$ rpm -q --whatprovides /etc/systemd/system

Otherwise, ACK.

thank for review Alexander, attaching updated patch.

Pushed to master: 9a1a409d63e30dcb939b672d352fc4aa7ba690fe
We also need a tmpfiles config changes because otherwise
/var/run/httpd/krbcache does not exist.

Patch attached.


Martin^3 Babinsky

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to