On Fri, Mar 2, 2018 at 10:33 PM, Waldek Hebisch <[email protected]> wrote: >> >> On Thu, Mar 1, 2018 at 11:47 PM, Waldek Hebisch >> <[email protected]> wrote: >> > oldk1331 wrote: >> >> >> >> Hi Waldek, you haven't commented on the following patches. >> >> Also, please merge the documentation fix patches as long as >> >> you see fit. >> >> >> >> > fix display of 'box': >> >> > >> >> > https://github.com/oldk1331/fricas/commit/2c02ad4ea19d7869327ed708a5e8ff93fd6bfc29.patch >> > >> > This is a workaround, but AFAICS OutputForm is correct and we should >> > render AGGLST in such a way that multiplication does not vanish. >> >> Currently 'box' only accepts one argument, so there is no point to >> wrap it inside AGGLST. > > 1) AGGLST is a legal output form so it should render correctly. > 2) Wrapping or not 'box' in AGGLST is a semantic decision. We should > not make such decisions to work around rendering problems.
OK, so the real problem here is how FriCAS handles output of a product A*B: Currently FriCAS produces "AB" by default, and only inserts additional whitespace when needed. We should change that to produce "A B" by default, and only eliminates whitespace when needed. Still, in this case, I think my patch is valid, there is no point to wrap argument in 'AGGLST' for 'box'. >> >> > trace.boot : call 'clearClams' after 'clearConstructorCaches': >> >> > >> >> > https://github.com/oldk1331/fricas/commit/1ae84818ee9fdfa98dfb6586907cd71abca8ffdf.patch >> > >> > It is not clear for me if we should do this. >> >> In your reply to "[BUG] strange behavior caused by ')trace'" in 2017 Dec 7, >> you showed your support for this change. > > Well, partially. The real bug is in different place and the > patch just masks most obvious breakage. The patch may > be part of full solution, but ATM we just loose a testcase and > create false confidence in users: currently tracing of Expression > like domains only works when domains are freshly reinitialized > after clear operations. So it is a similar story with ")compile": ')compile' and ')trace' both invalidates cache, so EXPR should be created again after )compile/)trace. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
