oldk1331 wrote:
>
> On Mon, Feb 26, 2018 at 2:35 AM, Waldek Hebisch
>
> >> I wish my 10 patches that imporves the TeXmacs interface
> >> could also get merged, so that I can upstream relevant
> >> parts to TeXmacs project.
> >
> > Which ones? I see 7 patches marked "texmacs". I looked at
>
> The 3 patches between them is also used.
>
> > one, "texmacs : move texmacs init code into lisp file; add variable
> > fricasi..."
> > and have the following comments:
> > - fricas-lisp.lisp is very bad place for this code. The intent of
> > fricas-lisp.lisp is define a dialect of Lisp (a virtual machine
> > if you prefer to think in that way) custmised for supporting
> > FriCAS. It is for low-level code, frequently dependent on Lisp
> > implementation. Functions there should not depend on anything
> > that we define at higher layers. The 'init-texmacs' function
> > is just ordinary interpter function, in fact it seems that it
> > could be easily written in Boot
> > - AFAICS initialization of texmacs interface was done via eval
> > due to flexibility (initialization code can be changed just
> > by editing the script, without any need to touch binaries).
> > I am not sure if this flexibility is needed, but also do
> > not see reason to change the current way. Could you explain
> > why you want to move the code?
>
> I'm just uncomfortable with having 440 characters lisp code
> in one line in shell script.
I see. This is ugly but we do such things in other places
too. Texmacs person with little FriCAS experience is
probably more comfortable with such line than with
looking into FriCAS source for init code.
>
> And another bug fix:
>
> fix ^ : (%, NNI) -> % in Factored
>
> test case: "factor(6)^0" returns "1" instead of "2^0*3^0"
AFAICS "1" is the correct result. What you propose would
probably break user code which expects that factors have
positive exponents. Actually, when looking at your other
patch I noticed that Factored internally uses negative
exponents and maybe 0 too. This looks wrong, but does
not do much charm as long as it is confined to internals
of Factored. Users should see positive exponents.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
