On Mon, Feb 26, 2018 at 8:56 PM, Waldek Hebisch <[email protected]> wrote: >> >> And another bug fix: >> >> fix ^ : (%, NNI) -> % in Factored >> >> test case: "factor(6)^0" returns "1" instead of "2^0*3^0" > > AFAICS "1" is the correct result. What you propose would
Yes, I mean after my patch, it returns "1", current code is wrong. > probably break user code which expects that factors have > positive exponents. Actually, when looking at your other > patch I noticed that Factored internally uses negative > exponents and maybe 0 too. This looks wrong, but does I also fix that in a later commit, fr.spad : change INT to NNI in Rep of FR : https://github.com/oldk1331/fricas/commit/be7be94ea799cb19a164052b0f8f4e10a956345c.patch But this patch requires some of the previous changes to fr.spad to be applied first. > not do much charm as long as it is confined to internals There is one internal usage in 'exquo' by using 'reciprocal', I have fixed that also. > of Factored. Users should see positive exponents. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
