On 03 Oct 2001 22:06:56 -0400, Suzanne Britton wrote: > > I've been tinkering with the FVWM 2.4.2 source code lately, trying to rectify > one of its few remaining lacks of themability :-) I've developed a patch which > adds a new type of TitleStyle. You can specify up to six pixmaps for the > titlebar in each state: main, under text, left of text, right of text, far > left, and far right (the first two are tiled, the rest aren't). This allows > FVWM to do a quite pleasing rendition of themes like Eazel-Blue and Crux > (though without the fancy borders). > > The config syntax looks like this currently: > TitleStyle Fancy <state> <main pixmap> <far left> <left of text> > <under text> <right of text> <far right> > > You can specify "no pixmap" at any position by substituting '-' for a pixmap > filename. The main pixmap will be tiled over any resulting empty spaces.
I wanted to work on titlebar inhancements, because a titlebar is not configurable in FVWM as opposed to other window managers. But I didn't have a good design to start with it (and I am not an X programmer anyway). Your solution seems to be complete enough and does a minimal change. Some notes about a "bloatness". I don't remember we had a consensus not to extend a titlebar functionality. If I missed it, please post a thread url. Instead I remember at least 5 user requests to be able to define a colorful pixmap that still leaves text readable. So users definitely would like your patch. (And fvwm-themes is the biggest user for that reason.) Tim suggested to move all fancy decorations to FvwmDecor module, but I am not sure how serious is this suggestion (i.e. who can implement this). Dominik and some others agreed that TitleStyle/ButtonStyle/BorderStyle commands should be dropped in favor of per-window styles using colorsets. But this does not mean the current configurability of these commands should be dropped, so, when such transformation happens your extended titlebar implementation could be reused together with the existing one. > Bearing in mind that the patch is currently buggy (titleunder pixmap > often doesn't update properly), unpolished, and the work of a complete > FVWM/X programming newbie, you can find it attached to this e-mail and > apply it to 2.4.2 via "patch -p0 <patchfile" from the top source dir. You > also have to #define FANCY_TITLEBARS in config.h to activate any of > the new code. > > Would there be any interest in integrating this into the main source tree? I am interesting to support an inclusion of this or updated patch. I have some questions, I am not sure what the correct answer should be. How is UseTitleStyle option of ButtonStyle affected? Is the main pixmap used in this case? How the continuation problem is solved? I mean, if some pixmaps are not defined will the main pixmap started again and again or one continued pixmap be used? What happens if a text is wider than a titlebar?.. Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
