On Sat, Oct 06, 2001 at 10:19:59PM +0000, Mikhael Goikhman wrote: > On 03 Oct 2001 22:06:56 -0400, Suzanne Britton wrote: > > > > I've been tinkering with the FVWM 2.4.2 source code lately, trying to > > rectify > > one of its few remaining lacks of themability :-) I've developed a patch > > which > > adds a new type of TitleStyle. You can specify up to six pixmaps for the > > titlebar in each state: main, under text, left of text, right of text, far > > left, and far right (the first two are tiled, the rest aren't). This allows > > FVWM to do a quite pleasing rendition of themes like Eazel-Blue and Crux > > (though without the fancy borders). > > > > The config syntax looks like this currently: > > TitleStyle Fancy <state> <main pixmap> <far left> <left of text> > > <under text> <right of text> <far right> > > > > You can specify "no pixmap" at any position by substituting '-' for a pixmap > > filename. The main pixmap will be tiled over any resulting empty spaces. > > I wanted to work on titlebar inhancements, because a titlebar is not > configurable in FVWM as opposed to other window managers. But I didn't > have a good design to start with it (and I am not an X programmer anyway). > Your solution seems to be complete enough and does a minimal change. > > Some notes about a "bloatness". I don't remember we had a consensus not to > extend a titlebar functionality. If I missed it, please post a thread url.
Doh, now that I come to think of it, this was all discusses long before you joined the workers list. > Instead I remember at least 5 user requests to be able to define a colorful > pixmap that still leaves text readable. So users definitely would like your > patch. (And fvwm-themes is the biggest user for that reason.) > > Tim suggested to move all fancy decorations to FvwmDecor module, but I am > not sure how serious is this suggestion This was completely serious. > (i.e. who can implement this). ;-) > Dominik and some others agreed that TitleStyle/ButtonStyle/BorderStyle > commands should be dropped in favor of per-window styles using colorsets. I still hesitate to actually do this. The planned changes would mean: 1) Rewrite TitleStyle, BorderStyle, and ButtonStyle commands as styles. 2) Integrate the remaining window looks related commands into styles (e.g. HilightColors/HilightColorset). 3) Remove all code related to decors. 4) Don't provide backwards compatibility without being able to write a conversion script. Many of the more complex configs would be broken. But if we don't forget about compüatibility, rewriting that stuff does not make sense at all. The benefits are simpler and cleaner code and a more user friendly syntax. > But this does not mean the current configurability of these commands > should be dropped, so, when such transformation happens your extended > titlebar implementation could be reused together with the existing one. Agreed. Dominik ^_^ ^_^ -- Dominik Vogt, email: [EMAIL PROTECTED] LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20 -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]