On 9/2/26 6:24 PM, wangjue wrote:
So the sh4 failure in my tester is almost certainly unrelated to this patch.
So I've pushed this version to the trunk. THanks for your patience.
For the future, please consider including testcases. There's numerous
folks that can help with that process. For this issue I would have
likely done a risc-v specific test because we can control things via
-mbranch-cost to verify that at a particular branch cost the 3
conditional move sequence if-converts.
Thanks for investigating the SH4 failure and pushing the patch to trunk.
And I’ll add the corresponding test case as soon as possible.
Thanks.
An FYI. The compiler seems to have gotten dramatically slower in the
last 24hrs. We're going to need to bisect that and evaluate. I was
worried a bit about the compile-time performance of your patch, so
naturally to see a 2X increase in compile time after commiting is
concerning.
Jeff
