Hi Jue, I collected performance data with this patch on an x86 machine, with SPEC CPU2017/2026, there is no regression. I have a slight concern: Why is only the new sequence costed in parallel, and not the original sequence? This leaves the comparison unfair.
Thanks, Lili. > -----Original Message----- > From: wangjue <[email protected]> > Sent: Thursday, September 3, 2026 8:24 AM > To: Jeff Law <[email protected]>; gcc-patches <gcc- > [email protected]> > Cc: rdapp.gcc <[email protected]>; richard.guenther > <[email protected]>; wangjue.wangjue > <[email protected]> > Subject: Re: [PATCH v4] ifcvt: Account for parallelism when costing noce > sequences > > > > > So the sh4 failure in my tester is almost certainly unrelated to this patch. > > > So I've pushed this version to the trunk. THanks for your patience. > > > For the future, please consider including testcases. There's numerous > > folks that can help with that process. For this issue I would have > > likely done a risc-v specific test because we can control things via > > -mbranch-cost to verify that at a particular branch cost the 3 > > conditional move sequence if-converts. > > Thanks for investigating the SH4 failure and pushing the patch to trunk. > And I’ll add the corresponding test case as soon as possible. > > > Best regards, > Wang Jue
