> On June 17, 2014, 2:54 p.m., Andreas Hansson wrote: > > configs/common/FSConfig.py, line 348 > > <http://reviews.gem5.org/r/2301/diff/2/?file=39993#file39993line348> > > > > I do not understand why this is not covered by the last statement, i.e. > > the Pci config space until the end of 64-bit space.
"[pci_config_address_space_base, Addr.max]" was the PCI config space, which only contains PCI config data (e.g. BAR0-5, VendorID, ...) linux kernel config PCI BARx when probe device, remap ioport/iomem of device to host's address space (e.g. in my 32MB memory config, ethernet device's iomem was mapped to "10000000-1001ffff : 0000:00:02.0") the BARx was 32-bit length and must be less than 4GB which is not covered by [pci_config_address_space_base, Addr.max] p.s. this patch will not work when pci device support 64-bit memory BAR in the future, because kernel may config PCI BARx above 4GB - Jiuyue ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5139 ----------------------------------------------------------- On June 16, 2014, 1:06 a.m., Jiuyue Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2301/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 1:06 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > config: add ethernet support for x86 fullsystem > > This patch add a IGbE_e1000 ethernet device to x86 fs system. To make it work > properly, > following changes were also made to FSConfig.py: > > - add [mem_size-1(or 3GB for >4GB memory), 0xFFFFFFFF] to bridge's ranges > for kernel configured pci device memory, > access to pci address space will pass though membus to bridge > > - add IGbE_e1000 to x86_sys.pc.ethernet > > - connect x86_sys.pc.ethernet.pio/config/dma to x86_sys.iobus > > - swap bus_id of ISA/PCI in X86 IntelMPTable > In gem5 Pc::calcPciConfigAddr(), it required "assert(bus==0)", but linux > kernel cannot > config ethernet device connected to ISA bus, so we swap bus_id of ISA/PCI > > > Diffs > ----- > > configs/common/FSConfig.py b2850bdcec070052f3a0f5efa8bf748eca1f5d44 > > Diff: http://reviews.gem5.org/r/2301/diff/ > > > Testing > ------- > > > Thanks, > > Jiuyue Ma > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev