> On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote:
> > configs/common/FSConfig.py, line 431
> > <http://reviews.gem5.org/r/2301/diff/3/?file=40047#file40047line431>
> >
> > I might be wrong here, but I think the InterruptLine is actually the
> > interrupt line as seen by the APIC. It doesn't have anything to do with the
> > actual CPU interrupt since the APIC sorts out the routing. If this is the
> > case, get rid of that part of the comment to avoid confusion.
Yes, you are right. The InterruptLine is the interrupt line as seen by the
APIC. I will remove these comments.
An interesting thing is when I change this value in python config, kernel also
see the same change. I have no idea of why this happened, maybe kernel init irq
routing table using hardware probed InterruptLine when system startup? I only
found irq assign in generic pci driver
"linux-2.6.28.4/drivers/pci/probe.c:664", but it is not used by x86 arch.
660 /*
661 * Read interrupt line and base address registers.
662 * The architecture-dependent code can tweak these, of course.
663 */
664 static void pci_read_irq(struct pci_dev *dev)
665 {
666 unsigned char irq;
667
668 pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq);
669 dev->pin = irq;
670 if (irq)
671 pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
672 dev->irq = irq;
673 }
- Jiuyue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2301/#review5190
-----------------------------------------------------------
On June 18, 2014, 1:42 a.m., Jiuyue Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2301/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 1:42 a.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> config: add ethernet support for x86 fullsystem
>
> This patch add a IGbE_e1000 ethernet device to x86 fs system. To make it work
> properly,
> following changes were also made to FSConfig.py:
>
> - add [mem_size-1(or 3GB for >4GB memory), 0xFFFFFFFF] to bridge's ranges
> for kernel configured pci device memory,
> access to pci address space will pass though membus to bridge
>
> - add IGbE_e1000 to x86_sys.pc.ethernet
>
> - connect x86_sys.pc.ethernet.pio/config/dma to x86_sys.iobus
>
> - swap bus_id of ISA/PCI in X86 IntelMPTable
> In gem5 Pc::calcPciConfigAddr(), it required "assert(bus==0)", but linux
> kernel cannot
> config ethernet device connected to ISA bus, so we swap bus_id of ISA/PCI
>
>
> Diffs
> -----
>
> configs/common/FSConfig.py b2850bdcec070052f3a0f5efa8bf748eca1f5d44
>
> Diff: http://reviews.gem5.org/r/2301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiuyue Ma
>
>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
