----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5190 -----------------------------------------------------------
Could you split this into two (or potentially three) different patches? The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP. As far as I'm concerned that particular part of the patch can be submitted separately right away as it is a small bug fixes that is limited to a few lines. I'm not so sure about the bridge ranges though. The PCI specification seems to allow devices to be mapped to pretty much any region of the memory space, so we can probably not do what you're doing currently to determine the range. Unfortunately, I can't think of a good solution off the top of my head. I'll discuss it with some colleagues and get back to you. configs/common/FSConfig.py <http://reviews.gem5.org/r/2301/#comment4746> I might be wrong here, but I think the InterruptLine is actually the interrupt line as seen by the APIC. It doesn't have anything to do with the actual CPU interrupt since the APIC sorts out the routing. If this is the case, get rid of that part of the comment to avoid confusion. - Andreas Sandberg On June 18, 2014, 3:42 a.m., Jiuyue Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2301/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 3:42 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > config: add ethernet support for x86 fullsystem > > This patch add a IGbE_e1000 ethernet device to x86 fs system. To make it work > properly, > following changes were also made to FSConfig.py: > > - add [mem_size-1(or 3GB for >4GB memory), 0xFFFFFFFF] to bridge's ranges > for kernel configured pci device memory, > access to pci address space will pass though membus to bridge > > - add IGbE_e1000 to x86_sys.pc.ethernet > > - connect x86_sys.pc.ethernet.pio/config/dma to x86_sys.iobus > > - swap bus_id of ISA/PCI in X86 IntelMPTable > In gem5 Pc::calcPciConfigAddr(), it required "assert(bus==0)", but linux > kernel cannot > config ethernet device connected to ISA bus, so we swap bus_id of ISA/PCI > > > Diffs > ----- > > configs/common/FSConfig.py b2850bdcec070052f3a0f5efa8bf748eca1f5d44 > > Diff: http://reviews.gem5.org/r/2301/diff/ > > > Testing > ------- > > > Thanks, > > Jiuyue Ma > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
