> On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote: > > Could you split this into two (or potentially three) different patches? > > > > The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP. > > As far as I'm concerned that particular part of the patch can be submitted > > separately right away as it is a small bug fixes that is limited to a few > > lines. > > > > I'm not so sure about the bridge ranges though. The PCI specification seems > > to allow devices to be mapped to pretty much any region of the memory > > space, so we can probably not do what you're doing currently to determine > > the range. Unfortunately, I can't think of a good solution off the top of > > my head. I'll discuss it with some colleagues and get back to you.
Split into three patches may be better: 1) PCI/ISA bus ID fixes 2) add/connect ethernet device 3) bridge range fixes I will do this split latter tomorrow. About the bridge range, I have tried to modify recvRangeChange() interface of Bridge: change bridge's slave port range when its master side changed. I think this should be a better solution than current one. But I failed to deal with the address conflict of mem_ctrls and iobridge/iocache in membus. T_T - Jiuyue ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5190 ----------------------------------------------------------- On June 18, 2014, 1:42 a.m., Jiuyue Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2301/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 1:42 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > config: add ethernet support for x86 fullsystem > > This patch add a IGbE_e1000 ethernet device to x86 fs system. To make it work > properly, > following changes were also made to FSConfig.py: > > - add [mem_size-1(or 3GB for >4GB memory), 0xFFFFFFFF] to bridge's ranges > for kernel configured pci device memory, > access to pci address space will pass though membus to bridge > > - add IGbE_e1000 to x86_sys.pc.ethernet > > - connect x86_sys.pc.ethernet.pio/config/dma to x86_sys.iobus > > - swap bus_id of ISA/PCI in X86 IntelMPTable > In gem5 Pc::calcPciConfigAddr(), it required "assert(bus==0)", but linux > kernel cannot > config ethernet device connected to ISA bus, so we swap bus_id of ISA/PCI > > > Diffs > ----- > > configs/common/FSConfig.py b2850bdcec070052f3a0f5efa8bf748eca1f5d44 > > Diff: http://reviews.gem5.org/r/2301/diff/ > > > Testing > ------- > > > Thanks, > > Jiuyue Ma > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
