----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3185/#review7749 -----------------------------------------------------------
src/mem/request.hh (line 206) <http://reviews.gem5.org/r/3185/#comment6699> HSA in the name somehow? src/mem/request.hh (line 308) <http://reviews.gem5.org/r/3185/#comment6698> HSA specific? src/mem/request.hh (line 753) <http://reviews.gem5.org/r/3185/#comment6700> It is somewhat unfortunate how many extra functions we end up with, given the limited use. Could we at least wrap all these in an HSA comment section so that it is clear that they are really only used by the APU? - Andreas Hansson On Dec. 23, 2015, 4:50 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3185/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 4:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11275:a9868b18de7a > --------------------------- > mem: misc flags for AMD gpu model > > This patch add support to mark memory requests/packets with attributes defined > in HSA, such as memory order and scope. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Exports.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/protocol/RubySlicc_Types.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/request.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/common/DataBlock.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/slicc_interface/RubyRequest.hh > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/system/RubyPort.cc d9a0136ab8cc4b3cf4821d064140b857e60db0dd > > Diff: http://reviews.gem5.org/r/3185/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
