> On Dec. 24, 2015, 9:11 a.m., Andreas Hansson wrote: > > src/mem/request.hh, line 206 > > <http://reviews.gem5.org/r/3185/diff/4/?file=52302#file52302line206> > > > > HSA in the name somehow?
I'm not sure if it makes sense to use "HSA" here, since "HSA" is meant very broadly to describe the system, while these are specific parameters of the memory spaces/hierarchy (e.g. we'll probably use these if/when we merge in GPGPU-Sim with an NVIDIA-like GPU). However, I agree it would be nice if these flags were named something more descriptive, since "ExtraFlags" is pretty obtuse. Maybe something like "MemHierParamFlags", or "MemSpaceConfigFlags"? - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3185/#review7749 ----------------------------------------------------------- On Dec. 23, 2015, 4:50 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3185/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 4:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11275:a9868b18de7a > --------------------------- > mem: misc flags for AMD gpu model > > This patch add support to mark memory requests/packets with attributes defined > in HSA, such as memory order and scope. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Exports.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/protocol/RubySlicc_Types.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/request.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/common/DataBlock.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/slicc_interface/RubyRequest.hh > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/system/RubyPort.cc d9a0136ab8cc4b3cf4821d064140b857e60db0dd > > Diff: http://reviews.gem5.org/r/3185/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
