----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3185/#review7879 -----------------------------------------------------------
There seems b src/mem/protocol/RubySlicc_Exports.sm (line 44) <http://reviews.gem5.org/r/3185/#comment6829> seems unrelated src/mem/protocol/RubySlicc_Exports.sm (line 59) <http://reviews.gem5.org/r/3185/#comment6830> unrelated? src/mem/protocol/RubySlicc_Exports.sm (line 170) <http://reviews.gem5.org/r/3185/#comment6832> This seems unrelated src/mem/protocol/RubySlicc_Types.sm (line 129) <http://reviews.gem5.org/r/3185/#comment6831> seems orthogonal src/mem/request.hh (line 210) <http://reviews.gem5.org/r/3185/#comment6827> Where do these come from? Is there a spec somewhere? A pointer would be good. src/mem/request.hh (line 760) <http://reviews.gem5.org/r/3185/#comment6828> Given that these flags are all very specific and used by a single module, is it worth holding off on all the getters and simply rely on the getMemSpaceConfigFlags()? src/mem/ruby/system/RubyPort.cc (line 239) <http://reviews.gem5.org/r/3185/#comment6833> This seems unrelated src/mem/ruby/system/RubyPort.cc (line 473) <http://reviews.gem5.org/r/3185/#comment6834> unrelated There seems to be a few unrelated changes here. - Andreas Hansson On Jan. 13, 2016, 9:24 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3185/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 9:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11279:e858f2256ccb > --------------------------- > mem: misc flags for AMD gpu model > > This patch add support to mark memory requests/packets with attributes defined > in HSA, such as memory order and scope. > > > Diffs > ----- > > src/mem/ruby/common/DataBlock.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/slicc_interface/RubyRequest.hh > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/ruby/system/RubyPort.cc d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/protocol/RubySlicc_Exports.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/protocol/RubySlicc_Types.sm > d9a0136ab8cc4b3cf4821d064140b857e60db0dd > src/mem/request.hh d9a0136ab8cc4b3cf4821d064140b857e60db0dd > > Diff: http://reviews.gem5.org/r/3185/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
