I was going to say when I saw this line in your earlier patch that you must have missed my rant a few weeks back about never ever putting "using namespace" in a header file.
I'm glad it's gone, but you should just fold this patch in with the one where it's introduced so that we never see it in the first place (see hg qfold). Steve On Thu, Apr 9, 2009 at 10:54 PM, Korey Sewell <[email protected]>wrote: > # HG changeset patch > # User Korey Sewell <[email protected]> > # Date 1239342519 14400 > # Node ID 1ea36de4c34568f7a3561fb9b7ed7393b725692b > # Parent 2ac6e5d7d8aa30b4f82417401f0c97f0339b505e > Remove namespace from header file. Causes compiler issues that are hard to > find > > diff -r 2ac6e5d7d8aa -r 1ea36de4c345 src/cpu/inorder/inorder_dyn_inst.hh > --- a/src/cpu/inorder/inorder_dyn_inst.hh Fri Apr 10 01:48:39 2009 > -0400 > +++ b/src/cpu/inorder/inorder_dyn_inst.hh Fri Apr 10 01:48:39 2009 > -0400 > @@ -56,9 +56,6 @@ > #include "mem/packet.hh" > #include "sim/system.hh" > > -using namespace TheISA; > - > - > /** > * @file > * Defines a dynamic instruction context for a inorder CPU model. > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
