-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeroen Roovers wrote: > I spotted that too but didn't remember putting it in black and white. :) > > The order ("first maintainer as assignee" or "first maintainer/herd as > assignee") is open to discussion and I think this is the proper forum to > have that discussion.
It seems sensible to me. I would've thought that being more specific would surely be better? Splitting them up means those who are mostly in charge of a package see it easily, and it's also then easier to spot packages that only have a herd, rather than them getting lost in all the packages that do have individual maintainers... I've attached a quick patch that should fix up assign.py to add all the herds on the end. Since the order of the second item onwards doesn't matter, all herds are added at the end. If we do need an ordering (like maintainer1, herd1, maintainer2, maintainer3, herd2) then it'll need a more complex patch... Hope this helps, Mike 5:) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklg7p8ACgkQu7rWomwgFXoDwACcCDBD5Dj/F//7Bxq+zIB1/GPZ UHQAnA82J6UxuHva7uEXmEL9wuNDMkIk =SRmT -----END PGP SIGNATURE-----
diff --git a/assign.py b/assign.py index 82d894b..c7c2c59 100644 --- a/assign.py +++ b/assign.py @@ -54,6 +54,7 @@ def get_pkg_cat(string): def get_maintainer_for(directory): """ returns a priority-sorted list of maintainers for a given CAT or CAT/PN """ cc =  + hcc =  try: if not heXML: globals()['heXML'] = et.parse(HERDS) @@ -65,7 +66,7 @@ def get_maintainer_for(directory): if thisherd.findtext("name") == elem.text: herdmail = thisherd.findtext("email") if herdmail: - cc.append(herdmail) + hcc.append(herdmail) elif elem.tag == "maintainer": email = elem.findtext("email") if not email: @@ -75,6 +76,7 @@ def get_maintainer_for(directory): cc.remove(email) else: cc.append(email) + cc.extend(hcc) except Exception: pass
Description: Binary data