The dependency on the driver is not a problem, if you do not have permission to distribute it as part of geotools you can mark it as "provided" (and it will be up to those installing the datastore to provide there own driver).
Is it available from a maven repo anywhere? Or is it truly a manual download process. Jody On Thu, Mar 24, 2022 at 1:52 AM George Dewar <gde...@linz.govt.nz> wrote: > Hi all, > > > > I have just put up a PR to add a JDBC datasource module for Informix > <https://github.com/geotools/geotools/pull/3828>, however I didn’t > realise at first that it should have gone into unsupported first. I don’t > mind putting it into unsupported first, but Andrea suggested that maybe it > could go straight into supported-land if it meets the requirements. > > > > Here is my assessment of where it’s at: > > > > - Visibility/Module Status > - For module status (4 stars): > - IP - all code is either written from scratch by me, or adapted > from the MySQL plugin and in either case, covered by the contributor > agreement. The copyright header is present in all files. (*tick)* > - Releasable - no known bugs (*tick)* > - Used in anger - has been used in Production for >1 year via > GeoServer (*tick)* > - Optimised - we have not carefully analysed the performance of > all aspects of it, but it appears to work efficiently for our use > case > - Supported - documentation is there, and LINZ is willing to > commit some time to support (*tick)* > - In terms of visibility, I’d be happy once it’s in to send a > separate email just announcing that Informix is now supported. A blog > post > about its use in GeoServer could be a possibility too. > - IP check - is the dependency on the Informix JDBC driver > <https://mvnrepository.com/artifact/com.ibm.informix/jdbc/4.50.7.1> a > problem? If so, is there a solution? > - Developers Guide - I think it meets all of these to at least the > extent that other JDBC plugins do, but it would take more time to carefully > check them all more thoroughly > - Test coverage - this is mostly determined by the tests in the super > classes, but the test coverage should be similar to the MySQL plugin I used > as a reference. I have not yet run the coverage check but I can soon. > - Documentation - yes, I added documentation to the same level as > other JDBC data sources > - Ask to be included in the next release - perhaps that could be a > later step? > > > > I am very open to the view that it should be in unsupported first as is > standard but I figure some tailored advice won’t hurt. If it *does *go in > unsupported, does that mean I can’t make the online tests run via GitHub > actions? > > > > Kind regards, > > > > *George Dewar* > > > *Senior Agile Developer, STEP Property System Infrastructure* > > *E* *gde...@linz.govt.nz <gde...@linz.govt.nz> | DDI 04 830 9968 | M 027 > 344 0353* > > > > * Wellington Office, Level 10, Radio New Zealand House, 155 The Terrace PO > Box 5501, Wellington 6145, New Zealand | T 04 460 0110 * > *W **www.linz.govt.nz <http://www.linz.govt.nz/>** | **data.linz.govt.nz* > <http://www.data.linz.govt.nz/> > > > > ------------------------------ > > This message contains information, which may be in confidence and may be > subject to legal privilege. If you are not the intended recipient, you must > not peruse, use, disseminate, distribute or copy this message. If you have > received this message in error, please notify us immediately (Phone 0800 > 665 463 or i...@linz.govt.nz) and destroy the original message. LINZ > accepts no responsibility for changes to this email, or for any > attachments, after its transmission from LINZ. Thank You. > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- -- Jody Garnett
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
