Hi George, checking the driver... It has a custom license. I was hoping we were past this, but yeah, we have had proprietary drivers in the past too. Do you know if the combination of GeoTools code with it, or GeoServer code with it, would be considered problematic by lawyers?
For the rest, the other bits seem satisfactory and would allow the driver to go straight into support (at least, as far as I can see). I won't be able to perform a review of the PR today, too many other PRs going on. Cheers Andrea On Thu, Mar 24, 2022 at 9:51 PM George Dewar <gde...@linz.govt.nz> wrote: > Thanks Jody. It’s available through Maven - see here > <https://mvnrepository.com/artifact/com.ibm.informix/jdbc/4.50.7.1>. I > think I’ll mark it as “provided” as you suggest. > > > > *From:* Jody Garnett <jody.garn...@gmail.com> > *Sent:* Friday, 25 March 2022 4:23 a.m. > *To:* George Dewar <gde...@linz.govt.nz> > *Cc:* geotools-devel@lists.sourceforge.net > *Subject:* Re: [Geotools-devel] Informix JDBC datasource plugin - > supported or not? > > > > The dependency on the driver is not a problem, if you do not have > permission to distribute it as part of geotools you can mark it as > "provided" (and it will be up to those installing the datastore to provide > there own driver). > > > > Is it available from a maven repo anywhere? Or is it truly a manual > download process. > > > > Jody > > > > On Thu, Mar 24, 2022 at 1:52 AM George Dewar <gde...@linz.govt.nz> wrote: > > Hi all, > > > > I have just put up a PR to add a JDBC datasource module for Informix > <https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgeotools%2Fgeotools%2Fpull%2F3828&data=04%7C01%7Cgdewar%40linz.govt.nz%7C7d82608969304acf3b8508da0daa2be5%7C2134e9617e384c34a22b10da5466b725%7C0%7C0%7C637837321793447540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MAHxQxgiRkxYzqqwMIH4cuGaMqhmlEqZ6M977%2F%2FDaKQ%3D&reserved=0>, > however I didn’t realise at first that it should have gone into unsupported > first. I don’t mind putting it into unsupported first, but Andrea suggested > that maybe it could go straight into supported-land if it meets the > requirements. > > > > Here is my assessment of where it’s at: > > > > - Visibility/Module Status > > > - For module status (4 stars): > > > - IP - all code is either written from scratch by me, or adapted from > the MySQL plugin and in either case, covered by the contributor > agreement. > The copyright header is present in all files. (*tick)* > - Releasable - no known bugs (*tick)* > - Used in anger - has been used in Production for >1 year via > GeoServer (*tick)* > - Optimised - we have not carefully analysed the performance of > all aspects of it, but it appears to work efficiently for our use > case > - Supported - documentation is there, and LINZ is willing to > commit some time to support (*tick)* > > > - In terms of visibility, I’d be happy once it’s in to send a separate > email just announcing that Informix is now supported. A blog post about > its > use in GeoServer could be a possibility too. > > > - IP check - is the dependency on the Informix JDBC driver > > <https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmvnrepository.com%2Fartifact%2Fcom.ibm.informix%2Fjdbc%2F4.50.7.1&data=04%7C01%7Cgdewar%40linz.govt.nz%7C7d82608969304acf3b8508da0daa2be5%7C2134e9617e384c34a22b10da5466b725%7C0%7C0%7C637837321793447540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hLJIaVJ6NLizgbCYW%2Bm%2FEoI9gGimvn29B4jmzx9AOXQ%3D&reserved=0> > a problem? If so, is there a solution? > - Developers Guide - I think it meets all of these to at least the > extent that other JDBC plugins do, but it would take more time to carefully > check them all more thoroughly > - Test coverage - this is mostly determined by the tests in the super > classes, but the test coverage should be similar to the MySQL plugin I used > as a reference. I have not yet run the coverage check but I can soon. > - Documentation - yes, I added documentation to the same level as > other JDBC data sources > - Ask to be included in the next release - perhaps that could be a > later step? > > > > I am very open to the view that it should be in unsupported first as is > standard but I figure some tailored advice won’t hurt. If it *does *go in > unsupported, does that mean I can’t make the online tests run via GitHub > actions? > > > > Kind regards, > > > > *George Dewar* > > > *Senior Agile Developer, STEP Property System Infrastructure* > > *E* *gde...@linz.govt.nz <gde...@linz.govt.nz> | DDI 04 830 9968 | M 027 > 344 0353* > > > > * Wellington Office, Level 10, Radio New Zealand House, 155 The Terrace PO > Box 5501, Wellington 6145, New Zealand | T 04 460 0110 * > *W **www.linz.govt.nz > <https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linz.govt.nz%2F&data=04%7C01%7Cgdewar%40linz.govt.nz%7C7d82608969304acf3b8508da0daa2be5%7C2134e9617e384c34a22b10da5466b725%7C0%7C0%7C637837321793447540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XpfLGzd2DMnr1goT7LLwVy9JFBTmU%2FwsfDi%2BNeA0o8U%3D&reserved=0>** > | > **data.linz.govt.nz* > <https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.data.linz.govt.nz%2F&data=04%7C01%7Cgdewar%40linz.govt.nz%7C7d82608969304acf3b8508da0daa2be5%7C2134e9617e384c34a22b10da5466b725%7C0%7C0%7C637837321793447540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xY0YgZlr7kUHwYGcNLUpPTCWkbv5PXu%2BNaeKmEEGBzE%3D&reserved=0> > > > > > ------------------------------ > > > This message contains information, which may be in confidence and may be > subject to legal privilege. If you are not the intended recipient, you must > not peruse, use, disseminate, distribute or copy this message. If you have > received this message in error, please notify us immediately (Phone 0800 > 665 463 or i...@linz.govt.nz) and destroy the original message. LINZ > accepts no responsibility for changes to this email, or for any > attachments, after its transmission from LINZ. Thank You. > > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > <https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Fgeotools-devel&data=04%7C01%7Cgdewar%40linz.govt.nz%7C7d82608969304acf3b8508da0daa2be5%7C2134e9617e384c34a22b10da5466b725%7C0%7C0%7C637837321793447540%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xCQIEW1UAgFh8AA7H%2B0cvH3uZt8SguEame73uAugVtQ%3D&reserved=0> > > -- > > -- > > Jody Garnett > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
