Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: Code-Review-1 (1 comment) I see no good reason for this change. You are breaking the ABI and basically not using the extra field "type" of the new struct. https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h File include/osmocom/sgsn/gtphub.h: https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h@377 PS2, Line 377: struct osmo_gsn_address addr; You are breaking ABI here, length of struct is different. include/osmocom/gsm/gsm23003.h 59:struct osmo_gsn_address { 60- enum osmo_gsn_addr_type type; 61- uint8_t length; 62- uint8_t addr[16]; 63-}; -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:58:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
