Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12352/2/src/gprs/gtphub.c File src/gprs/gtphub.c: https://gerrit.osmocom.org/#/c/12352/2/src/gprs/gtphub.c@196 PS2, Line 196: gsna->length = 4; if using the new struct, should also populate the type member throughout the code. Alternatively spread API doc everywhere that the field is ignored, but that's ugly IMHO. That kind of makes it not worthwhile bothering, I guess. -- To view, visit https://gerrit.osmocom.org/12352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a Gerrit-Change-Number: 12352 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Sat, 05 Jan 2019 03:59:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
